diff options
| author | sillylaird <sillyfanboy@gmail.com> | 2026-09-03 00:33:59 +0000 |
|---|---|---|
| committer | sillylaird <sillyfanboy@gmail.com> | 2026-09-03 00:33:59 +0000 |
| commit | 898b52edcb47bcb3e9d6106e74ca73e74ea01e70 (patch) | |
| tree | 85c6ee5ad58b860144551184d4cf86b560c62b91 /.agents/skills/code-review-excellence/references | |
| download | www-898b52edcb47bcb3e9d6106e74ca73e74ea01e70.tar.gz www-898b52edcb47bcb3e9d6106e74ca73e74ea01e70.zip | |
Diffstat (limited to '')
3 files changed, 40 insertions, 0 deletions
diff --git a/.agents/skills/code-review-excellence/references/code-review-best-practices.md b/.agents/skills/code-review-excellence/references/code-review-best-practices.md new file mode 100644 index 0000000..65c37bb --- /dev/null +++ b/.agents/skills/code-review-excellence/references/code-review-best-practices.md @@ -0,0 +1,19 @@ +# Code Review Best Practices + +## Default review order +1. Understand intent and scope. +2. Check architecture and correctness. +3. Check tests and failure handling. +4. Check security and performance risks. +5. Leave clear, prioritized comments. + +## Comment severity +- `blocking` - correctness, security, data loss, major maintainability issue +- `important` - should be fixed before merge if practical +- `nit` - polish only + +## Good reviewer habits +- summarize first, +- separate required changes from suggestions, +- quote the code path or failure mode, +- praise good decisions when they matter. diff --git a/.agents/skills/code-review-excellence/references/common-bugs-checklist.md b/.agents/skills/code-review-excellence/references/common-bugs-checklist.md new file mode 100644 index 0000000..5e62425 --- /dev/null +++ b/.agents/skills/code-review-excellence/references/common-bugs-checklist.md @@ -0,0 +1,9 @@ +# Common Bugs Checklist + +- null / undefined handling +- off-by-one and empty-input behavior +- race conditions or double-submit paths +- missing authorization checks +- silent error swallowing +- expensive loops or repeated queries +- test gaps on unhappy paths diff --git a/.agents/skills/code-review-excellence/references/security-review-guide.md b/.agents/skills/code-review-excellence/references/security-review-guide.md new file mode 100644 index 0000000..d15619f --- /dev/null +++ b/.agents/skills/code-review-excellence/references/security-review-guide.md @@ -0,0 +1,12 @@ +# Security Review Guide + +## Check for +- unsanitized input, +- SQL or shell injection, +- insecure deserialization, +- secret leakage, +- missing authz checks, +- unsafe filesystem or network defaults. + +## Review note pattern +`Blocking: this path accepts untrusted input and passes it to X without validation.` |