blob: 65c37bb0d243452e18addb2f5584f4a356edb5b2 (
plain) (
blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
|
# Code Review Best Practices
## Default review order
1. Understand intent and scope.
2. Check architecture and correctness.
3. Check tests and failure handling.
4. Check security and performance risks.
5. Leave clear, prioritized comments.
## Comment severity
- `blocking` - correctness, security, data loss, major maintainability issue
- `important` - should be fixed before merge if practical
- `nit` - polish only
## Good reviewer habits
- summarize first,
- separate required changes from suggestions,
- quote the code path or failure mode,
- praise good decisions when they matter.
|
